fix: multi-prefix replacement in binary files #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
approved these changes
Mar 19, 2024
wolfv
force-pushed
the
fix-prefix-replacement
branch
from
2302de6 to
78e6d78
Compare
baszalmstra
added a commit
that referenced
this pull request
Mar 19, 2024
## 🤖 New release * `rattler`: 0.19.3 -> 0.19.4 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `rattler` <blockquote> ## [0.19.4](rattler-v0.19.3...rattler-v0.19.4) - 2024-03-19 ### Fixed - multi-prefix replacement in binary files ([#570](#570)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pkg-configpackage encodes (in the binary) a "PATH" variable that looks something like:So far we only replaced the initial prefix placeholder, and skipped past the rest.
With this change we first get the whole "c-string" (until the
\0), and then replace each occurence of the prefix in the c-string. The padding is then added to make sure that the strings are of the same length.